linux-kernel - Re: [PATCHv4 2/2] clk: socfpga: add a clock driver for the Arria 10 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150521221733.GB1885@codeaurora.org>
Date:	Thu, 21 May 2015 15:17:33 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	dinguyen@...nsource.altera.com
Cc:	mturquette@...aro.org, dinh.linux@...il.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 2/2] clk: socfpga: add a clock driver for the Arria 10
 platform

On 05/19, dinguyen@...nsource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@...nsource.altera.com>
> 
> The clocks on the Arria 10 platform is a bit different than the Cyclone/Arria 5
> platform that it should just have it's own driver.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@...nsource.altera.com>
> ---

Applied to clk-next. One note below.

> +	of_property_read_string(node, "clock-output-names", &clk_name);
> +
> +	init.name = clk_name;
> +	init.ops = ops;
> +	init.flags = 0;
> +	while (i < SOCFPGA_MAX_PARENTS && (parent_name[i] =
> +			of_clk_get_parent_name(node, i)) != NULL)
> +		i++;

Perhaps this should be a generic clk framework helper.
	
	int of_clk_parent_something(node, array, size)

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/