linux-kernel - Re: [PATCH] arch: alpha: kernel: remove deprecated call to pci_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEdQ38EaE6f0MDQiKrdHu16aXAM5S0j+h2XA-gUkqjzdb1-DnA@mail.gmail.com>
Date:	Wed, 20 May 2015 22:51:12 -0700
From:	Matt Turner <mattst88@...il.com>
To:	Pierre Chevalier <pierrechevalier83@...il.com>
Cc:	Richard Henderson <rth@...ddle.net>,
	linux-alpha <linux-alpha@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch: alpha: kernel: remove deprecated call to pci_get_slot

On Thu, Feb 5, 2015 at 1:17 PM, Pierre Chevalier
<pierrechevalier83@...il.com> wrote:
> According to Documentation/PCI/pci.txt, pci_get_slot has been
> superseded by pci_get_domain_bus_and_slot.
>
> Signed-off-by: Pierre Chevalier <pierrechevalier83@...il.com>
> ---
>  arch/alpha/kernel/sys_miata.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/alpha/kernel/sys_miata.c b/arch/alpha/kernel/sys_miata.c
> index d5b9776..7b98b40 100644
> --- a/arch/alpha/kernel/sys_miata.c
> +++ b/arch/alpha/kernel/sys_miata.c
> @@ -182,7 +182,8 @@ miata_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
>
>         if((slot == 7) && (PCI_FUNC(dev->devfn) == 3)) {
>                 u8 irq=0;
> -               struct pci_dev *pdev = pci_get_slot(dev->bus, dev->devfn & ~7);
> +               struct pci_dev *pdev =
> +                       pci_get_domain_bus_and_slot(dev->bus, dev->devfn & ~7);

Given that pci_get_domain_bus_and_slot takes three arguments, I don't
think this compiles.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/