[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1432188990.5092.12.camel@mhfsdcap03>
Date: Thu, 21 May 2015 14:16:30 +0800
From: Yong Wu <yong.wu@...iatek.com>
To: Matthias Brugger <matthias.bgg@...il.com>
CC: Rob Herring <robh+dt@...nel.org>, Joerg Roedel <joro@...tes.org>,
"Robin Murphy" <robin.murphy@....com>,
Will Deacon <will.deacon@....com>,
"Daniel Kurtz" <djkurtz@...gle.com>,
Tomasz Figa <tfiga@...gle.com>,
Lucas Stach <l.stach@...gutronix.de>,
Mark Rutland <mark.rutland@....com>,
"Catalin Marinas" <catalin.marinas@....com>,
<linux-mediatek@...ts.infradead.org>,
Sasha Hauer <kernel@...gutronix.de>,
srv_heupstream <srv_heupstream@...iatek.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
<iommu@...ts.linux-foundation.org>,
Paul Bolle <pebolle@...cali.nl>, Arnd Bergmann <arnd@...db.de>,
<mitchelh@...eaurora.org>, <k.zhang@...iatek.com>,
<youhua.li@...iatek.com>
Subject: Re: [PATCH v2 4/6] soc: mediatek: Add SMI driver
Hi Matthias,
Thanks very much for your suggestion.
Abort the smi clock name, Could you help check below.
The others I will improve in next time.
On Tue, 2015-05-19 at 13:14 +0200, Matthias Brugger wrote:
> 2015-05-15 11:43 GMT+02:00 Yong Wu <yong.wu@...iatek.com>:
> > This patch add SMI(Smart Multimedia Interface) driver. This driver is
> > responsible to enable/disable iommu and control the clocks of each local arbiter.
> >
[snip]
> > +
> > +#define SMI_LARB_MMU_EN (0xf00)
> > +#define F_SMI_MMU_EN(port) (1 << (port))
> > +
> > +enum {
> > + MTK_CLK_APB,
> > + MTK_CLK_SMI,
> > + MTK_CLK_MAX,
>
> Maybe add something like:
> MTK_CLK_FIRST = MTK_CLK_APB,
> to make the for loops better readable.
>
Then, Is it like this? :
enum {
MTK_CLK_FIRST = MTK_CLK_APB,
MTK_CLK_SMI,
MTK_CLK_MAX,
}
or the CLK_SMI also need MTK_CLK_SECOND = MTK_CLK_SMI.
> > +};
> > +
> > +struct mtk_smi_common {
> > + void __iomem *base;
>
> That seems to be never used. Please delete it.
>
> > + struct clk *clk[MTK_CLK_MAX];
> > +};
> > +
> > +struct mtk_smi_larb {
> > + void __iomem *base;
> > + spinlock_t portlock; /* lock for config port */
> > + struct clk *clk[MTK_CLK_MAX];
> > + struct device *smi;
> > +};
> > +
> Thanks,
> Matthias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists