linux-kernel - Re: [PATCH v9 3/5] crypto: drbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1887173.hBZISiAer1@tauon>
Date:	Thu, 21 May 2015 08:53:13 +0200
From:	Stephan Mueller <smueller@...onox.de>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	pebolle@...cali.nl, andreas.steffen@...ongswan.org, tytso@....edu,
	sandyinchina@...il.com, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 3/5] crypto: drbg - add async seeding operation

Am Donnerstag, 21. Mai 2015, 14:36:18 schrieb Herbert Xu:

Hi Herbert,

>On Thu, May 21, 2015 at 08:10:13AM +0200, Stephan Mueller wrote:
>> The cancel operation is needed as otherwise my drbg context handle will be
>> removed by the crypto API during the sleep. That is the whole reason why
>> wait_event_interruptible is used.
>> 
>> So, even when using an uninterruptible sleep, the crypto API has no
>> knowledge about it and I have to serialize the destruction code path with
>> the async callback.
>
>I understand.  But if you use the uniterruptible version at least
>you won't have to deal with bogus early returns.

Thank you for pointing that out - I have seen that too. But the crux is that 
when using wait_event, the cancel function to serialize the destruction code 
path will *not* return at all, even when the async callback function completed 
successfully. Hence the choice for wait_event_interruptible
>
>The cancel by itself will *not* cause wait_event_interruptible
>to return early.  Somebody has to send it a signal for that to
>happen.

Correct. But I can only wake it up with a handle on urandom_init_wait on which 
the wait sleeps. That handle lives in random.c. So, to wake it up, I need 
another piece of code in random.c. That piece of code used to be the 
get_blocking_random_bytes_cancel function I offered in previous patches.

As Ted mentioned, he did not want to much code in random.c for this. In 
addition, if I understand you correctly in previous emails, it would be 
acceptable to wait until the callback was triggered (and thus causing the 
caller module to be not unloadable for that period of time.


Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/