linux-kernel - [PATCHv2] edd: support original Phoenix EDD 3.0 information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 May 2015 09:39:44 +0200
From:	Hannes Reinecke <hare@...e.de>
To:	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Johannes Thumshirn <jtumshirn@...e.com>,
	Hannes Reinecke <hare@...e.de>, Paul Bolle <pebolle@...cali.nl>
Subject: [PATCHv2] edd: support original Phoenix EDD 3.0 information

The original Phoenix EDD 3.0 specification (as found in
eg http://mbldr.sourceforge.net/specsedd30.pdf) has a
device path length of 36, not 44.
All the other fields are identical, so we can trivially support
both formats.

Cc: Paul Bolle <pebolle@...cali.nl>
Signed-off-by: Hannes Reinecke <hare@...e.de>
---
 drivers/firmware/edd.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index e229576..92bc0e8 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -8,6 +8,8 @@
  * BIOS Enhanced Disk Drive Services (EDD)
  * conformant to T13 Committee www.t13.org
  *   projects 1572D, 1484D, 1386D, 1226DT
+ * and the original Phoenix BIOS EDD 3.0 spec from
+ * <http://mbldr.sourceforge.net/specsedd30.pdf>
  *
  * This code takes information provided by BIOS EDD calls
  * fn41 - Check Extensions Present and
@@ -545,8 +547,9 @@ edd_has_edd30(struct edd_device *edev)
 	}
 
 
-	/* We support only T13 spec */
-	if (info->params.device_path_info_length != 44)
+	/* We support T13 d1572 and the original Phoenix spec */
+	if (info->params.device_path_info_length != 44 &&
+	    info->params.device_path_info_lenght != 36)
 		return 0;
 
 	for (i = 30; i < info->params.device_path_info_length + 30; i++)
-- 
1.8.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/