linux-kernel - Re: [PATCH 4/5] phy: cygnus: pcie: Add Cygnus PCIe PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432194775.21715.118.camel@x220>
Date:	Thu, 21 May 2015 09:52:55 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Ray Jui <rjui@...adcom.com>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	linux-kernel@...r.kernel.org,
	"JD (Jiandong) Zheng" <jdzheng@...adcom.com>,
	Arun Parameswaran <arunp@...adcom.com>,
	bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH 4/5] phy: cygnus: pcie: Add Cygnus PCIe PHY support

On Tue, 2015-05-19 at 18:23 -0700, Ray Jui wrote:
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
 
> +config PHY_CYGNUS_PCIE
> +	bool "Broadcom Cygnus PCIe PHY driver"
> +	depends on ARCH_BCM_CYGNUS
> +	select GENERIC_PHY
> +	select PHY_IPROC_MDIO
> +	default ARCH_BCM_CYGNUS
> +	help
> +	  Enable this to support the Broadcom Cygnus PCIe PHY.
> +
> +	  The host communicates with the PHY through the iProc MDC/MDIO
> +	  interface.
> +
> +	  If unsure, say N.
> +
> +

> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile

> +obj-$(CONFIG_PHY_CYGNUS_PCIE)		+= phy-cygnus-pcie.o

> --- /dev/null
> +++ b/drivers/phy/phy-cygnus-pcie.c

> +#include <linux/module.h>

> +static const struct of_device_id cygnus_pcie_phy_match_table[] = {
> +	{ .compatible = "brcm,cygnus-pcie-phy" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, cygnus_pcie_phy_match_table);
> +
> +static struct platform_driver cygnus_pcie_phy_driver = {
> +	.driver = {
> +		.name		= "cygnus-pcie-phy",
> +		.of_match_table	= cygnus_pcie_phy_match_table,
> +	},
> +	.probe	= cygnus_pcie_phy_probe,
> +};
> +module_platform_driver(cygnus_pcie_phy_driver);
> +
> +MODULE_AUTHOR("Ray Jui <rjui@...adcom.com>");
> +MODULE_DESCRIPTION("Broadcom Cygnus PCIe PHY driver");
> +MODULE_LICENSE("GPL v2");

And here I guess you intend this to be buildable as a module. If that's
the intention I think PHY_CYGNUS_PCIE needs to be tristate.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/