linux-kernel - Re: [PATCH 06/16] NTB Pingpong Client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432198475.21715.137.camel@x220>
Date:	Thu, 21 May 2015 10:54:35 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Allen Hubbe <Allen.Hubbe@....com>
Cc:	linux-ntb@...glegroups.com, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, Jon Mason <jdmason@...zu.us>,
	Dave Jiang <dave.jiang@...el.com>
Subject: Re: [PATCH 06/16] NTB Pingpong Client

Similar nit as for 2/6.

On Wed, 2015-05-20 at 11:41 -0400, Allen Hubbe wrote:
> --- a/drivers/ntb/Kconfig
> +++ b/drivers/ntb/Kconfig
> @@ -14,6 +14,8 @@ if NTB
>  
>  source "drivers/ntb/hw/Kconfig"
>  
> +source "drivers/ntb/test/Kconfig"
> +
>  config NTB_TRANSPORT

> --- /dev/null
> +++ b/drivers/ntb/test/Kconfig

> +config NTB_PINGPONG
> +       tristate "NTB Simple Ping Pong Client"
> +       depends on NTB

Again, superfluous dependency.

> +       help
> +        This is a simple ping pong driver that exercises the scratchpads and
> +        doorbells of the ntb hardware.  This driver may be used to test that
> +        your ntb hardware and drivers are functioning at a basic level.
> +
> +        If unsure, say N.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/