linux-kernel - Re: [v6 6/8] iommu, x86: Setup Posted-Interrupts capability for Intel iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1505211249280.4225@nanos>
Date:	Thu, 21 May 2015 12:51:13 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Feng Wu <feng.wu@...el.com>
cc:	joro@...tes.org, dwmw2@...radead.org, jiang.liu@...ux.intel.com,
	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [v6 6/8] iommu, x86: Setup Posted-Interrupts capability for
 Intel iommu

On Thu, 21 May 2015, Feng Wu wrote:
> @@ -647,6 +647,20 @@ static int __init intel_enable_irq_remapping(void)
> +	/*
> +	 * Set Posted-Interrupts capability.
> +	 */
> +	if (!disable_irq_post) {
> +		intel_irq_remap_ops.capability |= 1 << IRQ_POSTING_CAP;
> +
> +		for_each_iommu(iommu, drhd)
> +			if (!cap_pi_support(iommu->cap)) {
> +				intel_irq_remap_ops.capability &=
> +						~(1 << IRQ_POSTING_CAP);
> +				break;
> +			}
> +	}
> +

> @@ -874,6 +894,20 @@ static int reenable_irq_remapping(int eim)
> +	/*
> +	 * Set Posted-Interrupts capability.
> +	 */
> +	if (!disable_irq_post) {
> +		intel_irq_remap_ops.capability |= 1 << IRQ_POSTING_CAP;
> +
> +		for_each_iommu(iommu, drhd)
> +			if (!cap_pi_support(iommu->cap)) {
> +				intel_irq_remap_ops.capability &=
> +						~(1 << IRQ_POSTING_CAP);
> +				break;
> +			}
> +	}
> +

Verbatim copy and paste. Ever heard about the concept of helper functions?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/