[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <10573000.xg2bp6EQuX@wuerfel>
Date: Thu, 21 May 2015 13:28:55 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Dave Gordon <david.s.gordon@...el.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Akinobu Mita <akinobu.mita@...il.com>,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
jbottomley@...n.com
Subject: Re: [PATCH] scsi: debug: fix type mismatch warning for sg_pcopy_from_buffer
On Thursday 21 May 2015 12:09:58 Dave Gordon wrote:
> From b304c5a99ea260eac1cf98ced5f3c79c793ad4fd Mon Sep 17 00:00:00 2001
> From: Dave Gordon <david.s.gordon@...el.com>
> Date: Thu, 21 May 2015 12:06:27 +0100
> Subject: [PATCH] scsi: resolve sg buffer const-ness issue
>
> do_device_access() takes a separate parameter to indicate the direction
> of data transfer, which it used to use to select the appropriate function
> out of sg_pcopy_{to,from}_buffer(). However these two functions now have
> different const-ness in their signatures, leading to compiler warnings.
>
> So this patch makes it bypass these wrappers and call the underlying
> function sg_copy_buffer() directly; this has the same calling style as
> do_device_access() i.e. a separate direction-of-transfer parameter and
> no pointers-to-const, so skipping the wrappers not only eliminates the
> warning, it also make the code simpler
>
> Signed-off-by: Dave Gordon <david.s.gordon@...el.com>
> ---
Acked-by: Arnd Bergmann <arnd@...db.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists