linux-kernel - RE: [PATCH 02/16] NTB Abstraction Layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 May 2015 11:32:26 +0000
From:	"Hubbe, Allen" <Allen.Hubbe@....com>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	"linux-ntb@...glegroups.com" <linux-ntb@...glegroups.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Jon Mason <jdmason@...zu.us>, Dave Jiang <dave.jiang@...el.com>
Subject: RE: [PATCH 02/16] NTB Abstraction Layer

From: Paul Bolle [mailto:pebolle@...cali.nl]
> On Wed, 2015-05-20 at 11:41 -0400, Allen Hubbe wrote:


> 
> (My mailer tells me this message is over 200KB in size. Did you consider
> offering bribes to get people to review this patch?)

I would have liked to send smaller patches, too.

I attempted to split this one in three:
1) add the ntb core driver and header file
2) change ntb_hw_intel driver to use new api
3) change ntb_transport driver to use new api

The problem is, any change to the old ntb_hw_intel (was ntb.ko), or ntb_transport, alone will cause the other not to work.

> 
> I just spotted two nits.
> 
> > --- a/drivers/ntb/Kconfig
> > +++ b/drivers/ntb/Kconfig
> >
> > +if NTB
> > +
> > +source "drivers/ntb/hw/Kconfig"
> > +
> > +config NTB_TRANSPORT
> > +       tristate "NTB Transport Client"
> > +       depends on NTB
> 
> Superfluous dependency.

I will remove depends NTB from this, and other things within if NTB.

I will also change the leading spaces to tabs.

> 
> > +       help
> > +        This is a transport driver that enables connected systems to
> exchange
> > +        messages over the ntb hardware.  The transport exposes a
> queue pair api
> > +        to client drivers.
> > +
> > +        If unsure, say N.
> > +
> > +endif # NTB
> 
> > --- /dev/null
> > +++ b/drivers/ntb/hw/intel/Kconfig
> 
> > +config NTB_INTEL
> > +       tristate "Intel Non-Transparent Bridge support"
> > +       depends on NTB
> 
> Ditto.
> 
> > +       depends on X86
> > +       help
> > +        This driver supports Intel NTB on capable Xeon and Atom
> hardware.
> > +
> > +        If unsure, say N.
> 
> Thanks,
> 
> 
> Paul Bolle

Thanks,
Allen