linux-kernel - Re: [PATCH v2] rcu: Deinline rcu_read_lock_sched_held() if DEBUG_LOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150521112852.6f276563@gandalf.local.home>
Date:	Thu, 21 May 2015 11:28:52 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Josh Triplett <josh@...htriplett.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Tejun Heo <tj@...nel.org>, Oleg Nesterov <oleg@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rcu: Deinline rcu_read_lock_sched_held() if
 DEBUG_LOCK_ALLOC

On Thu, 21 May 2015 17:09:47 +0200
Denys Vlasenko <dvlasenk@...hat.com> wrote:

> --- a/kernel/rcu/update.c
> +++ b/kernel/rcu/update.c
> @@ -62,6 +62,55 @@ MODULE_ALIAS("rcupdate");
>  
>  module_param(rcu_expedited, int, 0);
>  
> +#if defined CONFIG_DEBUG_LOCK_ALLOC && defined CONFIG_PREEMPT_COUNT

I thought defined required parenthesis. Doing a

  git grep '#if defined' shows most places in the kernel use it.

Although, I also did a git grep '#if defined *C' and it shows that
there are quite a few places that don't use it. I would be more
comfortable with adding the parenthesis and being in line with
the majority of the kernel:

#if defined(CONFIG_DEBUG_LOCK_ALLOC) && defined(CONFIG_PREEMPT_COUNT)

Rest seems fine.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/