linux-kernel - Re: [EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150521155125.GO3140@localhost>
Date:	Thu, 21 May 2015 21:21:25 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	dan.j.williams@...el.com, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after
 NULL check of pch pointer

On Tue, May 19, 2015 at 05:00:27AM +0000, Maninder Singh wrote:
>  EP-AA9D1F29B02341529D96C06444D8471D
Whats this, please sned patch ina proper format, git format-patch is your
friend, use it

> 
> Hi,
> Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer
patch title doesn't match expectations, use the right subsystem name, and
also please explain why yoy are doing this
> 
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Reviewed-By: Vaneet Narang <v.narang@...sung.com>
> ---
>  drivers/dma/pl330.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index a7d9d30..7e27144 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
>  {
>  	struct dma_pl330_desc *desc;
>  	struct dma_pl330_chan *pch = to_pchan(chan);
> -	struct pl330_dmac *pl330 = pch->dmac;
> +	struct pl330_dmac *pl330;
>  	int burst;
>  
>  	if (unlikely(!pch || !len))
>  		return NULL;
>  
> +	pl330 = pch->dmac;
> +
>  	desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
>  	if (!desc)
>  		return NULL;
> -- 
> 1.7.1
> 
> Thanks 
> Maninder Singh.¢éì¹».®&Þ~º&¶.¬–+-±éÝ¶.¥Šw®žË›±ÊâmçfiéàŠw¢žØ^n‡r¡ö¦zË.?ëh™¨èÚ&¢ø.®G«?éh®.(éšŽŠÝ¢j"?ú.¶.m§ÿï?êäz¹Þ–Šàþf£¢·hšˆ§~ˆmš
Nice signature!

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/