linux-kernel - Re: [PATCH 2/2] dma: amba-pl08x: Fix line over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 May 2015 21:29:52 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Jagan Teki <jteki@...nedev.com>
Cc:	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH 2/2] dma: amba-pl08x: Fix line over 80 characters

On Thu, May 21, 2015 at 12:41:10AM +0530, Jagan Teki wrote:
> This patch fixes line over 80 characters warninings while
> running checkpatch.pl
> 
> Signed-off-by: Jagan Teki <jteki@...nedev.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Vinod Koul <vinod.koul@...el.com>
> ---
>  drivers/dma/amba-pl08x.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 49d396e..a5d9cc9 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -646,7 +646,9 @@ static void pl08x_phy_alloc_and_start(struct pl08x_dma_chan *plchan)
>  
>  	ch = pl08x_get_phy_channel(pl08x, plchan);
>  	if (!ch) {
> -		dev_dbg(&pl08x->adev->dev, "no physical channel available for xfer on %s\n", plchan->name);
> +		dev_dbg(&pl08x->adev->dev,
> +			"no physical channel available for xfer on %s\n",
> +			plchan->name);
This looks bad to read including the below ones so I am going to decline it

-- 
~Vinod
>  		plchan->state = PL08X_CHAN_WAITING;
>  		return;
>  	}
> @@ -698,7 +700,8 @@ static void pl08x_phy_free(struct pl08x_dma_chan *plchan)
>  		}
>  
>  	if (!next) {
> -		list_for_each_entry(p, &pl08x->slave.channels, vc.chan.device_node)
> +		list_for_each_entry(p, &pl08x->slave.channels,
> +				vc.chan.device_node)

>  			if (p->state == PL08X_CHAN_WAITING) {
>  				next = p;
>  				break;
> @@ -1988,7 +1991,8 @@ static int pl08x_debugfs_show(struct seq_file *s, void *data)
>  	seq_printf(s, "\nPL08x virtual memcpy channels:\n");
>  	seq_printf(s, "CHANNEL:\tSTATE:\n");
>  	seq_printf(s, "--------\t------\n");
> -	list_for_each_entry(chan, &pl08x->memcpy.channels, vc.chan.device_node) {
> +	list_for_each_entry(chan, &pl08x->memcpy.channels,
> +			vc.chan.device_node) {
>  		seq_printf(s, "%s\t\t%s\n", chan->name,
>  			   pl08x_state_str(chan->state));
>  	}
> @@ -2172,7 +2176,8 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
>  			u32 val;
>  
>  			val = readl(ch->reg_config);
> -			if (val & (PL080N_CONFIG_ITPROT | PL080N_CONFIG_SECPROT)) {
> +			if (val & (PL080N_CONFIG_ITPROT |
> +					PL080N_CONFIG_SECPROT)) {
>  				dev_info(&adev->dev, "physical channel %d reserved for secure access only\n", i);
>  				ch->locked = true;
>  			}
> -- 
> 1.9.1
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/