linux-kernel - Re: [PATCH] mips: irq: Use DECLARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1432224631.20840.45.camel@perches.com>
Date:	Thu, 21 May 2015 09:10:31 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	linux-mips <linux-mips@...ux-mips.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Gabor Juhos <juhosg@...nwrt.org>,
	Manuel Lauss <manuel.lauss@...glemail.com>,
	John Crispin <blogic@...nwrt.org>
Subject: Re: [PATCH] mips: irq: Use DECLARE_BITMAP

On Thu, 2015-05-21 at 15:14 +0200, Ralf Baechle wrote:
> On Wed, May 20, 2015 at 05:44:54AM -0700, Joe Perches wrote:
> 
> > Use the generic mechanism to declare a bitmap instead of unsigned long.
> > 
> > This could fix an overwrite defect of whatever follows irq_map.
> > 
> > Not all "#define NR_IRQS <value>" are a multiple of BITS_PER_LONG so
> > using DECLARE_BITMAP allocates the proper number of longs required
> > for the possible bits.
> > 
> > For instance:
> > 
> > arch/mips/include/asm/mach-ath79/irq.h:#define NR_IRQS                  51
> > arch/mips/include/asm/mach-db1x00/irq.h:#define NR_IRQS 152
> > arch/mips/include/asm/mach-lantiq/falcon/irq.h:#define NR_IRQS 328
> 
> This only matters to user of the allocate_irqno() API and there is only
> on such platform, the IP27 which fortunately uses a NR_IRQS value that
> is a multiple of 64, so no impact.
> 
> Thanks anyway!

I think you should apply it anyway as it's an
error-prone style.

There are 3 mechanisms used today in the kernel
to declare bitmap arrays.

	DECLARE_BITMAP(array, size)
	unsigned long array[BITS_TO_LONGS(size)]
	unsigned long array[size/BITS_PER_LONG]

The first 2 are fine, the last has this defect
possible whenever size % BITS_PER_LONG != 0.

The series I sent converts all the uses of the
the possibly defective style.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/