linux-kernel - Re: [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 May 2015 20:03:43 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	"H. Nikolaus Schaller" <hns@...delico.com>
Subject: Re: [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from
 uevent

Hi,

On Tue, May 19, 2015 at 04:13:00PM +0900, Krzysztof Kozlowski wrote:
> Changes since v1:
> =================
> 1. Patch 2: fix invalid member used for container_of().
> 2. Patch 2: Replace WARN with pr_warn() in __power_supply_register()
>    if parent is missing.
> 
> 
> Description:
> ============
> This is an idea to fix issue in bq27x00 driver (and probably in others)
> reported by H. Nikolaus Schaller [0].
> 
> The fixes are marked RFC/RFT because:
> 1. I do not have bq27x00-like device. I confirmed this and tested on
>    modified drivers (max77693, ACPI AC). These drivers are not
>    impacted by the issue but one can easily adjust them to reproduce
>    the problem.
> 2. The first uevent coming from power_supply_register() is now
>    different because it won't contain device properties. I am
>    not sure how this impacts userspace.
> 
> Comments are welcomed.

Queued to for-next and fixes. I will not sent it to Torvalds before
Sunday, so that it gets some testing in next.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)