linux-kernel - Re: random: Wake up all getrandom(2) callers when pool is ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150521191739.GP2871@thunk.org>
Date:	Thu, 21 May 2015 15:17:39 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Stephan Mueller <smueller@...onox.de>, pebolle@...cali.nl,
	andreas.steffen@...ongswan.org, sandyinchina@...il.com,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: random: Wake up all getrandom(2) callers when pool is ready

On Thu, May 21, 2015 at 04:19:54PM +0800, Herbert Xu wrote:
> On Thu, May 21, 2015 at 09:55:17AM +0200, Stephan Mueller wrote:
> >
> > So, I will create a 2nd wait queue in random.c for uninterruptible waits, 
> > change the get_blocking_random_bytes back to void and use wait_event to wait 
> > for the initialization.
> 
> Hold your horses.  You don't need a second queue, you just need to
> change wake_up_interruptible to wake_up.
> 
> Hmm, in fact shouldn't this be wake_up_all? Otherwise what are the
> other getrandom(2) callers going to do? Ted?

Yes, this should definitely be wake_up_all()

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/