linux-kernel - Re: [PATCH v3 18/21] nd_btt: atomic sector updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4hjKxP-s65Y-MTk-hV8pe9fke9x65hyXmtzDXqJsPL4qw@mail.gmail.com>
Date:	Fri, 22 May 2015 14:39:51 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	"Elliott, Robert (Server Storage)" <Elliott@...com>
Cc:	"axboe@...nel.dk" <axboe@...nel.dk>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	"neilb@...e.de" <neilb@...e.de>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	Dave Chinner <david@...morbit.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andy Lutomirski <luto@...capital.net>,
	Jens Axboe <axboe@...com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>, "hch@....de" <hch@....de>
Subject: Re: [PATCH v3 18/21] nd_btt: atomic sector updates

On Fri, May 22, 2015 at 2:16 PM, Elliott, Robert (Server Storage)
<Elliott@...com> wrote:
>
>
>> -----Original Message-----
>> From: Linux-nvdimm [mailto:linux-nvdimm-bounces@...ts.01.org] On Behalf Of
>> Dan Williams
>> Sent: Wednesday, May 20, 2015 3:58 PM
>> To: axboe@...nel.dk
>> Cc: mingo@...nel.org; linux-nvdimm@...ts.01.org; neilb@...e.de;
>> gregkh@...uxfoundation.org; Dave Chinner; linux-kernel@...r.kernel.org; Andy
>> Lutomirski; Jens Axboe; linux-acpi@...r.kernel.org; H. Peter Anvin;
>> hch@....de
>> Subject: [PATCH v3 18/21] nd_btt: atomic sector updates
>>
>> From: Vishal Verma <vishal.l.verma@...ux.intel.com>
>>
> ...
>> diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig
>> index 00d9afe9475e..2b169806eac5 100644
>> --- a/drivers/block/nd/Kconfig
>> +++ b/drivers/block/nd/Kconfig
>> @@ -32,9 +32,25 @@ config BLK_DEV_PMEM
>>         capable of DAX (direct-access) file system mappings.  See
>>         Documentation/blockdev/nd.txt for more details.
>>
>> -       Say Y if you want to use a NVDIMM described by NFIT
>> +       Say Y if you want to use a NVDIMM described by ACPI, E820, etc...
>>
>>  config ND_BTT_DEVS
>> -     def_bool y
>> +     bool
>> +
>> +config ND_BTT
>> +     tristate "BTT: Block Translation Table (atomic sector updates)"
>> +     depends on LIBND
>> +     default LIBND
>> +     select ND_BTT_DEVS
>
> The ND_BTT option, which is presented during a kernel build,
> is missing help text. So is E820_PMEM in patch 3/21.
>

Right, but another alternative is hiding the ability to configure it
altogether.  Perhaps just build them in always.  I made them
configurable for those kernel size folks that like the ability to
throw away things they don't need, but this may be a degree of freedom
too far.  E820_PMEM is a bit more straightforward, and could use a
help comment like "you've already gone through the trouble to turn on
X86_PMEM_LEGACY, you had better turn on the driver too, otherwise
what's the point" :).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/