linux-kernel - Re: [PATCH] ARM: nommu: avoid deprecated source register on mov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150522230441.GN2067@n2100.arm.linux.org.uk>
Date:	Sat, 23 May 2015 00:04:41 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Stefan Agner <stefan@...er.ch>
Cc:	arnd@...db.de, will.deacon@....com, u.kleine-koenig@...gutronix.de,
	manabian@...il.com, mcoquelin.stm32@...il.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: nommu: avoid deprecated source register on mov

On Sat, May 23, 2015 at 12:46:52AM +0200, Stefan Agner wrote:
> @@ -106,32 +106,26 @@ ENTRY(secondary_startup)
>  	movs	r10, r5				@ invalid processor?
>  	beq	__error_p			@ yes, error 'p'
>  
> -	adr	r4, __secondary_data
> -	ldmia	r4, {r7, r12}
> -
>  #ifdef CONFIG_ARM_MPU
>  	/* Use MPU region info supplied by __cpu_up */
> +	ldr	r7, __secondary_data

Almost, you want this above the #ifdef though, as r7 is used below.
("set up the stack pointer").  Apart from that, I don't see any
obvious problems, thanks.

>  	ldr	r6, [r7]			@ get secondary_data.mpu_szr
>  	bl      __setup_mpu			@ Initialize the MPU
>  #endif
>  
> -	badr	lr, __after_proc_init		@ return address
> -	mov	r13, r12			@ __secondary_switched address
> +	badr	lr, 1f				@ return (PIC) address
>  	ldr	r12, [r10, #PROCINFO_INITFUNC]
>  	add	r12, r12, r10
>  	ret	r12
> -ENDPROC(secondary_startup)
> -
> -ENTRY(__secondary_switched)
> +1:	bl	__after_proc_init
>  	ldr	sp, [r7, #12]			@ set up the stack pointer

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/