[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAEnQRZBxX-YxU1u8PuE_8ApBpsEOU9XenFyhbKUbmTW4RzO+=w@mail.gmail.com>
Date: Fri, 22 May 2015 09:57:12 +0300
From: Daniel Baluta <daniel.baluta@...el.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Kevin Tsai <ktsai@...ellamicro.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Jonathan Cameron <jic23@...nel.org>,
Hartmut Knaack <knaack.h@....de>,
Lars-Peter Clausen <lars@...afoo.de>,
Peter Meerwald <pmeerw@...erw.net>,
Andrew Morton <akpm@...ux-foundation.org>,
"David S. Miller" <davem@...emloft.net>,
Mauro Carvalho Chehab <mchehab@....samsung.com>,
Arnd Bergmann <arnd@...db.de>, Joe Perches <joe@...ches.com>,
Jingoo Han <jingoohan1@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Roberta Dobrescu <roberta.dobrescu@...il.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@...ux.intel.com>,
devicetree@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
Subject: Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient
light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed
white space. - Removed unused include files. - Updated macro definitions. -
Renamed cm32181_chip pointer to chip.
On Fri, May 22, 2015 at 4:56 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Thu, May 21, 2015 at 05:30:40PM -0700, Kevin Tsai wrote:
>> Signed-off-by: Kevin Tsai <ktsai@...ellamicro.com>
>> ---
>
> Your whole changelog ended up in the Subject line :(
Hi Kevin,
Few comments:
1) Please also add a cover letter. Use --cover-letter parameter of git
format-patch.
2) Please create a patch for each logical change. Your current 1/6
patch should be
split in several small patches:
* 1/6 iio: light: cm32181: Update company name
* 2/6 iio: light: cm32181: Remove unused include files
* etc.
3) Please use specific wordings for commit subject. A subject like this:
"Updated Vishay Capella cm32181 ambient light sensor driver" doesn't say much.
thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists