linux-kernel - Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15C0AFDB-CA69-40E5-B65E-C559A5B5CE47@intel.com>
Date:	Fri, 22 May 2015 08:08:44 +0000
From:	"Drokin, Oleg" <oleg.drokin@...el.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
CC:	Michael Shuey <shuey@...due.edu>, Joe Perches <joe@...ches.com>,
	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"<gregkh@...uxfoundation.org>" <gregkh@...uxfoundation.org>,
	"<kernel-janitors@...r.kernel.org>" <kernel-janitors@...r.kernel.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	"<HPDD-discuss@...1.01.org>" <HPDD-discuss@...1.01.org>,
	"<lustre-devel@...ts.lustre.org>" <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl
 fixes


On May 22, 2015, at 1:06 AM, Julia Lawall wrote:

> On Thu, 21 May 2015, Michael Shuey wrote:
> 
>> That's a task (of many) I've been putting on the back burner until the code
>> is cleaner.  It's also a HUGE change, since there are debug macros
>> everywhere, and they all check a #define'd mask to see if they should fire,
>> and the behavior is likely governed by parts of the lustre user land tools
>> as well.
>> 
>> Suggestions are welcome.  Do other parts of the linux kernel define complex
>> debugging macros like these, or is this a lustre-ism?  Any suggestions on
>> how to handle this more in line with existing drivers?
> 
> Once you decide what to do, you can use Coccinelle to make the changes for
> you.  So you shouldn't be put off by the number of code sites to change.
> 
> The normal functions are pr_err, pr_warn, etc.  Perhaps you can follow
> Joe's suggestions if you really need something more complicated.

Ideally leaving CERROR/CDEBUG in Lustre would be desirable from my perspective.
It allows you fine grained control about what to collect and what to output
into a (quite finite) kernel buffer (and over a quite slow serial console)
and at the same time if you need more info, there's a buffer you can fetch
separately that can grow much bigger and there's even a way to run a special
daemon to scrub the buffer eagerly so none of it is lost.

Bye,
    Oleg--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/