linux-kernel - Re: [PATCH 2/2] drivers: ata: add support for Ceva sata host controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1432287264.27695.72.camel@x220>
Date:	Fri, 22 May 2015 11:34:24 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Suneel Garapati <suneel.garapati@...inx.com>
Cc:	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	Tejun Heo <tj@...nel.org>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, michals@...inx.com,
	sorenb@...inx.com, devicetree@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH 2/2] drivers: ata: add support for Ceva sata host
 controller

[Adding Bjorn.]

> On Thu, May 21, 2015 at 09:27:05AM +0530, Suneel Garapati wrote:
> > --- /dev/null
> > +++ b/drivers/ata/ahci_ceva.c

> > + * This program is free software; you can redistribute it and/or modify it
> > + * under the terms and conditions of the GNU General Public License,
> > + * version 2, as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope it will be useful, but WITHOUT
> > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> > + * more details.
> > + *
> > + * You should have received a copy of the GNU General Public License along with
> > + * this program. If not, see <http://www.gnu.org/licenses/>.

> > +MODULE_LICENSE("GPLv2");

You meant "GPL v2".

"GPLv2" is not one of the idents that pass license_is_gpl_compatible().
Loading a module with that ident should trigger a warning and taint the
kernel. See linux/module.h (or linux/license.h) for acceptable idents.

This is a bit of a gotcha. A patch that would have helped here was
posted in https://lkml.org/lkml/2015/4/7/824 . I don't know why that
patch didn't make it into checkpatch.pl. Bjorn?

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/