linux-kernel - Re: [PATCH 1/1] dw_mmc: insmod followed by rmmod will hung for eMMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 May 2015 15:21:26 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Prabu Thangamuthu <Prabu.T@...opsys.com>
Cc:	Seungwon Jeon <tgih.jun@...sung.com>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Manjunath M Bettegowda <Manjunath.MB@...opsys.com>
Subject: Re: [PATCH 1/1] dw_mmc: insmod followed by rmmod will hung for eMMC

On 18 May 2015 at 16:23, Prabu Thangamuthu <Prabu.T@...opsys.com> wrote:
> Removing dw_mmc driver immediately after inserting the dw_mmc driver is

I guess it hangs even if you remove it after a couple of days? :-)

Perhaps makes this a bit more clear?

> getting hung for eMMC device. Root cause for this issue is, dw_mci_remove
> will disable all the interrupts then it will call dw_mci_cleanup_slot.
> dw_mci_cleanup_slot is issuing CMD6 to disable boot partition access and
> it's waiting for command complete interrupt. Since INTMASK was already
> cleared by dw_mci_remove, command complete interrupt is not reaching
> the system. This leads to process hung.

/s dw_mci_remove / dw_mci_remove()

>
> Signed-off-by: Prabu Thangamuthu <prabu.t@...opsys.com>

This patch looks good overall, but please send a new version with
updated changelog. Moreover, please use "mmc: dw_mmc:" as prefix for
the commit message header.

Kind regards
Uffe

> ---
>  drivers/mmc/host/dw_mmc.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 5f5adaf..f0a0aff 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2941,15 +2941,15 @@ void dw_mci_remove(struct dw_mci *host)
>  {
>         int i;
>
> -       mci_writel(host, RINTSTS, 0xFFFFFFFF);
> -       mci_writel(host, INTMASK, 0); /* disable all mmc interrupt first */
> -
>         for (i = 0; i < host->num_slots; i++) {
>                 dev_dbg(host->dev, "remove slot %d\n", i);
>                 if (host->slot[i])
>                         dw_mci_cleanup_slot(host->slot[i], i);
>         }
>
> +       mci_writel(host, RINTSTS, 0xFFFFFFFF);
> +       mci_writel(host, INTMASK, 0); /* disable all mmc interrupt first */
> +
>         /* disable clock to CIU */
>         mci_writel(host, CLKENA, 0);
>         mci_writel(host, CLKSRC, 0);
> --
> 1.7.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/