linux-kernel - Re: [PATCH] livepatch: Let compiler put module initialized function to section ".init.text"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150522132528.GA20555@treble.redhat.com>
Date:	Fri, 22 May 2015 08:25:28 -0500
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Minfei Huang <mhuang@...hat.com>
Cc:	sjenning@...hat.com, jkosina@...e.cz, vojtech@...e.cz,
	live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
	Minfei Huang <mnfhuang@...il.com>
Subject: Re: [PATCH] livepatch: Let compiler put module initialized function
 to  section ".init.text"

On Fri, May 22, 2015 at 02:10:32PM +0800, Minfei Huang wrote:
> From: Minfei Huang <mnfhuang@...il.com>
> 
> Usually we prefer to let compiler put the module initialized function to
> section ".init.text". Thus this text in memory will be freed in future.
> 
> Once we add the "__init" preceding function name, we can use following
> command to find it in specfied section.
> 
>   $ objdump -t -j .init.text built-in.o
> 
>   built-in.o:     file format elf64-x86-64
> 
>   SYMBOL TABLE:
>   0000000000000000 l    d  .init.text	0000000000000000 .init.text
>   0000000000000000 l     F .init.text	000000000000004e klp_init
> 
> Signed-off-by: Minfei Huang <mnfhuang@...il.com>

The patch looks good but can you make the subject more concise?  Maybe
something like:

  livepatch: annotate klp_init() with __init

Thanks.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/