linux-kernel - Re: [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <555F343A.3040009@linaro.org>
Date:	Fri, 22 May 2015 14:50:50 +0100
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Patrick Lai <plai@...eaurora.org>, Mark Brown <broonie@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Banajit Goswami <bgoswami@...eaurora.org>,
	Kenneth Westfield <kwestfie@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF



On 22/05/15 14:21, Arnd Bergmann wrote:
> On Friday 22 May 2015 12:53:44 Srinivas Kandagatla wrote:
>> Thanks for looking at this patch.
>>
>> On 22/05/15 08:24, Arnd Bergmann wrote:
>>> On Thursday 21 May 2015 22:52:41 Srinivas Kandagatla wrote:
>>>>
>>>>    config SND_SOC_LPASS_CPU
>>>>           tristate
>>>> +       depends on OF
>>>>           select REGMAP_MMIO
>>>>
>>>>    config SND_SOC_LPASS_PLATFORM
>>>>           tristate
>>>> +       depends on OF
>>>>           select REGMAP_MMIO
>>>>
>>>>    config SND_SOC_LPASS_IPQ806X
>>>>
>>>
>>> Could you instead make the drivers compile without OF being set?
>>>
>>> I see that patch 7 and 8 introduces another two options doing
>>>
>>>
>>> +config SND_SOC_LPASS_APQ8016
>>> +       tristate
>>> +       depends on SND_SOC_QCOM
>>> +       select SND_SOC_LPASS_CPU
>>> +       select SND_SOC_LPASS_PLATFORM
>>> +
>>>
>>> +config SND_SOC_APQ8016_SBC
>>> +       tristate "SoC Audio support for APQ8016 SBC platforms"
>>> +       depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
>>> +       select SND_SOC_LPASS_APQ8016
>>> +       help
>>>
>>> so you get an obvious build failure here when SND_SOC_APQ8016_SBC
>>> gets selected with COMPILE_TEST on a platform that does not support OF.
>>>
>>
>> Yes, this would fail.
>> I think moving of_device_id structures in drivers under #ifdef CONFIG_OF
>> and removing the depends on OF would fix it.
>>
>
> Why?

Yes, you are correct we don't need the ifdef's anymore. I will send a 
fixup patch on top of what Mark has already applied.

--srini
>
> 	Arnd
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/