linux-kernel - Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150522145628.GB16473@krava.redhat.com>
Date:	Fri, 22 May 2015 16:56:28 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
Cc:	mingo@...hat.com, ak@...ux.intel.com,
	Michael Ellerman <mpe@...erman.id.au>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Paul Mackerras <paulus@...ba.org>, namhyung@...nel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C
 style file

On Tue, May 19, 2015 at 05:02:08PM -0700, Sukadev Bhattiprolu wrote:

SNIP

> +int main(int argc, char *argv[])
> +{
> +	int rc;
> +	int flags;

SNIP

> +
> +	rc = uname(&uts);
> +	if (rc < 0) {
> +		printf("%s: uname() failed: %s\n", argv[0], strerror(errno));
> +		goto empty_map;
> +	}
> +
> +	/* TODO: Add other flavors of machine type here */
> +	if (!strcmp(uts.machine, "ppc64"))
> +		arch = "powerpc";
> +	else if (!strcmp(uts.machine, "i686"))
> +		arch = "x86";
> +	else if (!strcmp(uts.machine, "x86_64"))
> +		arch = "x86";
> +	else {
> +		printf("%s: Unknown architecture %s\n", argv[0], uts.machine);
> +		goto empty_map;
> +	}

hum, wouldnt it be easier to pass the arch directly from the Makefile,
we should have it ready in the $(ARCH) variable..

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/