[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150522021730.GA7730@linux>
Date: Fri, 22 May 2015 07:47:30 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Shailendra Verma <shailendra.capricorn@...il.com>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>,
Kukjin Kim <kgene@...nel.org>,
Krzysztof Kozlowski <k.kozlowski@...sung.com>,
linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq:exynos-cpufreq - Fix for memory leak in case SOC
name does not match.
On 21-05-15, 23:59, Shailendra Verma wrote:
> During probe free the memory allocated to "exynos_info" in case of unknown
> SOC type.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@...il.com>
> ---
> drivers/cpufreq/exynos-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index 82d2fbb..b77923a 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -182,6 +182,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev)
> ret = exynos5250_cpufreq_init(exynos_info);
> } else {
> pr_err("%s: Unknown SoC type\n", __func__);
> + kfree(exynos_info);
> return -ENODEV;
> }
There is no point replicating this stuff. Use labels like: err_vdd_arm
to get this done. But you also need to make sure the right error gets
propagated.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists