linux-kernel - Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1432263965.20840.85.camel@perches.com>
Date:	Thu, 21 May 2015 20:06:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Michael Shuey <shuey@...due.edu>
Cc:	"Drokin, Oleg" <oleg.drokin@...el.com>, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"hpdd-discuss@...ts.01.org" <HPDD-discuss@...ts.01.org>,
	lustre-deve@...ts.lustre.org
Subject: Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl
 fixes

On Thu, 2015-05-21 at 17:47 -0400, Michael Shuey wrote:
> Any suggestions on other checkpatch warnings?  Most of what remains are
> "don't introduce new typedefs" warnings - should these be removed as well,
> or am I safe to leave these?

I'm personally not a big fan of non-enum typedefs unless
the typedef hides some arch or size specific information
that's otherwise hard to handle.

I think struct/function/native type equivalent typedefs
are better removed.

coccinelle is a good tool for this.

I rather like enum typedefs, but that's not a common view
in lk land.

> I ask because these changes will be huge, and
> are unlikely to improve readability (but I don't know where the kernel
> community stands on having billions of typedefs everywhere.

I counted slightly less than billions.  I got 281.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/