linux-kernel - Re: [lustre-devel] [PATCH 1/3] staging:lustre: remove tcpip abstraction from libcfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150522153929.GW22558@mwanda>
Date:	Fri, 22 May 2015 18:39:29 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Simmons, James A." <simmonsja@...l.gov>
Cc:	James Simmons <jsimmons@...radead.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	James Simmons <uja.ornl@...oo.com>,
	James Simmons <uja.ornl@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Oleg Drokin <oleg.drokin@...el.com>,
	"HPDD-discuss@...1.01.org" <HPDD-discuss@...1.01.org>,
	"lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>
Subject: Re: [lustre-devel] [PATCH 1/3] staging:lustre: remove tcpip
 abstraction from libcfs

On Fri, May 22, 2015 at 03:08:44PM +0000, Simmons, James A. wrote:
> >This patch does a lot of stuff all at once and it is hard to review.  It
> >could easily be broken into patches which are easy to review.
> 
> I have more very large patches. With breaking them up that means you are
> going to see hundreds of patches coming from me. 
> 

The problem here is that we have two upstreams which have diverged and
you're hopefully merging them into one upstream for the future.
Breaking things up into patches is a pain and it basically means you
have to do a lot of the work a second time.  It sucks for you and I
totally understand that...  :(

We regulary review 100+ patch series so that's not a big deal.

We still have to review a ball of code with it broken up or not broken
up but when it's broken up then I have scripts to strip out much of the
mechanical changes.

> >Ok in this next section we move functions around and rename them but
> >also introduce some bad changes in the new function.
> 
> Thanks for pointing out these bugs. We are still carrying these bugs in the
> OpenSFS branch. Once you approve these changes I will sync up lib-socket.c
> in the OpenSFS branch.
> 
> P.S
>       Does the 3rd patch look okay to you?

Yeah.  That looks fine.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/