linux-kernel - Re: [PATCH] init/do_mounts: Add create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555F5DD8.8070700@infradead.org>
Date:	Fri, 22 May 2015 09:48:24 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Vishnu Pratap Singh <vishnu.ps@...sung.com>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
CC:	cpgs@...sung.com
Subject: Re: [PATCH] init/do_mounts: Add create_dev() failure log

On 05/22/15 05:37, Vishnu Pratap Singh wrote:
> if create_dev() function fails to create the root mount device (/dev/root),
> then it goes to panic as root device not found but there is no check/log
> present in case of failure, So i have added the log in case it fails to create
> the root device. It will help in debugging.
> 
> Signed-off-by: Vishnu Pratap Singh <vishnu.ps@...sung.com>
> ---
>  init/do_mounts.h |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/init/do_mounts.h b/init/do_mounts.h
> index f5b978a..40c85e9 100644
> --- a/init/do_mounts.h
> +++ b/init/do_mounts.h
> @@ -15,8 +15,12 @@ extern int root_mountflags;
>  
>  static inline int create_dev(char *name, dev_t dev)
>  {
> +	int ret;
>  	sys_unlink(name);
> -	return sys_mknod(name, S_IFBLK|0600, new_encode_dev(dev));
> +	ret = sys_mknod(name, S_IFBLK|0600, new_encode_dev(dev));
> +	if(ret < 0)

	if (ret < 0)

> +		printk(KERN_ERR " Failed to create %s device !! err: %d\n", name, ret);

Don't need space before 'Failed'.

> +	return ret;
>  }
>  
>  #if BITS_PER_LONG == 32
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/