linux-kernel - Re: [EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1507989167.25151432264740747.JavaMail.weblogic@epmlwas06d>
Date:	Fri, 22 May 2015 03:19:02 +0000 (GMT)
From:	Maninder Singh <maninder1.s@...sung.com>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL
 check of pch pointer

EP-AA9D1F29B02341529D96C06444D8471D
Hi Vinod

>On Tue, May 19, 2015 at 05:00:27AM +0000, Maninder Singh wrote:
>>  EP-AA9D1F29B02341529D96C06444D8471D
>Whats this, please sned patch ina proper format, git format-patch is your
>friend, use it
>

This is auto generated no. from editor, so please ignore it, and i am resubmitting the patch, thanks for your feedback.

>> 
>> Hi,
>> Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer
>patch title doesn't match expectations, use the right subsystem name, and
>also please explain why yoy are doing this

Ok according to comments resubmitting . Please check new patch if it is appropriate. because this patch is also generated by git,
But i think editor does some malfunctioning.

>> 
>> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
>> Reviewed-By: Vaneet Narang <v.narang@...sung.com>
>> ---
>>  drivers/dma/pl330.c |    4 +++-
---cut---
>> Thanks 
>> Maninder Singh
>Nice signature!
>
>-- 
>~Vinod

From 76a6ef435065c10a0476038e8a08016878488dcb Mon Sep 17 00:00:00 2001
From: Maninder Singh <maninder1.s@...sung.com>
Date: Mon, 18 May 2015 17:53:11 +0530
Subject: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch

Currently pch pointer is already dereferenced before NULL check and thus we are getting below warning:
warn: variable dereferenced before check 'pch'

So initialize struct pl330_dmac *pl330 after NULL check of dma_pl330_chan *pch.

Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
Reviewed-by: Vaneet Narang <v.narang@...sung.com>
---
 drivers/dma/pl330.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index a7d9d30..7e27144 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
 {
 	struct dma_pl330_desc *desc;
 	struct dma_pl330_chan *pch = to_pchan(chan);
-	struct pl330_dmac *pl330 = pch->dmac;
+	struct pl330_dmac *pl330;
 	int burst;
 
 	if (unlikely(!pch || !len))
 		return NULL;
 
+	pl330 = pch->dmac;
+
 	desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
 	if (!desc)
 		return NULL;
-- 
1.7.1

Thanks
Maninder
............