linux-kernel - Re: [PATCH v7 6/7] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAS=xmgZ4GoKXY+yzqA0Sbf=D8gNi6kazXrbZH-4pY6wBDpzLA@mail.gmail.com>
Date:	Sat, 23 May 2015 08:45:31 +0800
From:	Brent Wang <wangbintian@...il.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Bintian <bintian.wang@...wei.com>,
	Mike Turquette <mturquette@...aro.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Xu Wei <xuwei5@...ilicon.com>,
	"xuejiancheng@...wei.com" <xuejiancheng@...wei.com>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	"sledge.yanwei@...wei.com" <sledge.yanwei@...wei.com>,
	linux-clk@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Will Deacon <will.deacon@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Kevin Hilman <khilman@...aro.org>,
	Mark Rutland <mark.rutland@....com>,
	Catalin Marinas <catalin.marinas@....com>,
	Haojian Zhuang <haojian.zhuang@...aro.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Olof Johansson <olof@...om.net>,
	Haifeng Yan <yanhaifeng@...il.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Guodong Xu <guodong.xu@...aro.org>,
	Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>,
	Tyler Baker <tyler.baker@...aro.org>,
	Kevin Hilman <khilman@...nel.org>,
	"xuyiping@...ilicon.com" <xuyiping@...ilicon.com>,
	"wangbinghui@...ilicon.com" <wangbinghui@...ilicon.com>,
	"zhenwei.wang@...ilicon.com" <zhenwei.wang@...ilicon.com>,
	"victor.lixin@...ilicon.com" <victor.lixin@...ilicon.com>,
	"puck.chen@...ilicon.com" <puck.chen@...ilicon.com>,
	"dan.zhao@...ilicon.com" <dan.zhao@...ilicon.com>,
	"huxinwei@...wei.com" <huxinwei@...wei.com>,
	"z.liuxinliang@...wei.com" <z.liuxinliang@...wei.com>,
	"heyunlei@...wei.com" <heyunlei@...wei.com>,
	XinWei Kong <kong.kongxinwei@...ilicon.com>,
	"w.f@...wei.com" <w.f@...wei.com>,
	"Liguozhu (Kenneth)" <liguozhu@...ilicon.com>
Subject: Re: [PATCH v7 6/7] clk: hi6220: Clock driver support for Hisilicon
 hi6220 SoC

Hello Stephen,

2015-05-23 3:17 GMT+08:00 Stephen Boyd <sboyd@...eaurora.org>:
> On 05/22/15 11:57, Brent Wang wrote:
>> Hello Stephen,
>>
>> 2015-05-23 2:41 GMT+08:00 Stephen Boyd <sboyd@...eaurora.org>:
>>> On 05/22, Stephen Boyd wrote:
>>>> On 05/22/15 11:30, Brent Wang wrote:
>>>>> Hello Stephen,
>>>>>
>>>>> 2015-05-22 13:20 GMT+08:00 Bintian <bintian.wang@...wei.com>:
>>>>>>> Is pl011 the uart device? Does it have a node in DT somewhere? If it
>>>>>>> does, then we could put the assigned-parents properties in that node so
>>>>>>> that when the pl011 probes the uart1 clock has its parent set to
>>>>>>> clk_150m. See the "Assigned clock parents and rates" section of
>>>>>>> Documentation/devicetree/bindings/clock/clock-bindings.txt.
>>>>>>>
>>>>>> I will verify this.
>>>>> Currently the "assigned-clock*" doesn't work for pl011 UART device
>>>>> node, maybe we will
>>>>> do some fix for its driver later or other modules.
>>>> Why doesn't it work?
>>>>
>>> Does this patch help?
>> Yes, it works!
>>
>> I also tested adding  "of_clk_set_defaults" to "pl011_probe()", and
>> "assigned-clock*"
>> also works.
>>
>> So you will submit another patch to fix this problem and I can revove
>> the "clk_set_parent"
>> from my patch, right ?
>>
>>
>
> How about you take it as part of your series? Or if you're planning on
> splitting out the clk patch to go through clk-tree I can apply it before
> applying the clock driver patch.
It's better you take it and I split my patch :)

>
>
> ----8<-----
>
> From: Stephen Boyd <sboyd@...eaurora.org>
> Subject: [PATCH] amba: Support clk parents and rates assigned in DT
>
> Add the call to of_clk_set_defaults() into the amba probe path so
> that devices on the amba bus can use the assigned rates and
> parents feature of the common clock framework.
>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---
>  drivers/amba/bus.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> index f0099360039e..350ed93d4281 100644
> --- a/drivers/amba/bus.c
> +++ b/drivers/amba/bus.c
> @@ -19,6 +19,7 @@
>  #include <linux/amba/bus.h>
>  #include <linux/sizes.h>
>  #include <linux/limits.h>
> +#include <linux/clk/clk-conf.h>
>
>  #include <asm/irq.h>
>
> @@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)
>         int ret;
>
>         do {
> +               ret = of_clk_set_defaults(dev->of_node, false);
> +               if (ret < 0)
> +                       break;
> +
>                 ret = dev_pm_domain_attach(dev, true);
>                 if (ret == -EPROBE_DEFER)
>                         break;
>
Tested-by: Bintian Wang <bintian.wang@...wei.com>

Thanks,

Bintian
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/