linux-kernel - Re: [PATCH] Input: stmpe-ts - enforce device tree only mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 May 2015 23:29:53 +0200
From:	Marek Vasut <marex@...x.de>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: stmpe-ts - enforce device tree only mode

On Saturday, May 23, 2015 at 06:41:50 PM, Dmitry Torokhov wrote:
> On May 23, 2015 9:38:54 AM PDT, Marek Vasut <marex@...x.de> wrote:
> >On Saturday, May 23, 2015 at 12:58:32 AM, Dmitry Torokhov wrote:
> >> The STMPE MFD is only used with device tree configured systems (and
> >
> >STMPE
> >
> >> MFD core depends on OF), so force the configuration to come from
> >
> >device
> >
> >> tree only.
> >> 
> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> >> ---
> >
> >Hi!
> >
> >[...]
> >
> >> @@ -351,14 +336,13 @@ static int stmpe_input_probe(struct
> >
> >platform_device
> >
> >> *pdev) idev->name = STMPE_TS_NAME;
> >> 
> >>  	idev->phys = STMPE_TS_NAME"/input0";
> >>  	idev->id.bustype = BUS_I2C;
> >> 
> >> -	idev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
> >> -	idev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
> >> 
> >>  	idev->open = stmpe_ts_open;
> >>  	idev->close = stmpe_ts_close;
> >>  	
> >>  	input_set_drvdata(idev, ts);
> >> 
> >> +	input_set_capability(idev, EV_KEY, BTN_TOUCH);
> >
> >Isn't this part of the patch dropping the EV_ABS evbit ?
> 
> No, on newer kernels input_set_abs_paramd() takes care of setting we EV_ABS
> in evbit as well.

Oh, I see, thanks for enlightening me!

Reviewed-by: Marek Vasut <marex@...x.de>

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/