linux-kernel - Re: [PATCH 12/19] ACPICA: ACPI 6.0: Add changes for MADT table.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555FC3AC.1090108@linaro.org>
Date:	Sat, 23 May 2015 08:02:52 +0800
From:	Hanjun Guo <hanjun.guo@...aro.org>
To:	"Zheng, Lv" <lv.zheng@...el.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"Brown, Len" <len.brown@...el.com>
CC:	Lv Zheng <zetalog@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"Moore, Robert" <robert.moore@...el.com>
Subject: Re: [PATCH 12/19] ACPICA: ACPI 6.0: Add changes for MADT table.

On 2015年05月22日 08:16, Zheng, Lv wrote:
> Hi,
>
>> From: Hanjun Guo [mailto:hanjun.guo@...aro.org]
>> Sent: Thursday, May 21, 2015 10:36 PM
>>
>> Hi Lv,
>>
>> On 2015年05月21日 10:31, Lv Zheng wrote:
>>> From: Bob Moore <robert.moore@...el.com>
>>>
>>> ACPICA commit 02cbb41232bccf7a91967140cab95d5f48291f21
>>>
>>> New subtable type. Some additions to existing subtables.
>>>
>>> Link: https://github.com/acpica/acpica/commit/02cbb412
>>> Signed-off-by: Bob Moore <robert.moore@...el.com>
>>> Signed-off-by: Lv Zheng <lv.zheng@...el.com>
>>> ---
>> [...]
>>>
>>>    /* Masks for Flags field above */
>>> @@ -819,7 +822,7 @@ struct acpi_madt_generic_interrupt {
>>>    #define ACPI_MADT_PERFORMANCE_IRQ_MODE  (1<<1)	/* 01: Performance Interrupt Mode */
>>>    #define ACPI_MADT_VGIC_IRQ_MODE         (1<<2)	/* 02: VGIC Maintenance Interrupt mode */
>>>
>>> -/* 12: Generic Distributor (ACPI 5.0) */
>>> +/* 12: Generic Distributor (ACPI 5.0 + ACPI 6.0 changes) */
>>>
>>>    struct acpi_madt_generic_distributor {
>>>    	struct acpi_subtable_header header;
>>> @@ -827,7 +830,8 @@ struct acpi_madt_generic_distributor {
>>>    	u32 gic_id;
>>>    	u64 base_address;
>>>    	u32 global_irq_base;
>>> -	u32 reserved2;		/* reserved - must be zero */
>>> +	u8 version;
>>
>> version filed in generic distributor has following values,
>>
>> /* Values for gic_version in Generic Distributor  (ACPI 6.0) */
>>
>> enum acpi_madt_gic_ver_type
>> {
>>           ACPI_MADT_GIC_VER_UNKNOWN       = 0,
>>           ACPI_MADT_GIC_VER_V1            = 1,
>>           ACPI_MADT_GIC_VER_V2            = 2,
>>           ACPI_MADT_GIC_VER_V3            = 3,
>>           ACPI_MADT_GIC_VER_V4            = 4,
>>           ACPI_MADT_GIC_VER_RESERVED      = 5     /* 5 and greater are
>> reserved */
>> };
>>
>> should we put it here, or locate it to ARM64 arch related head
>> file?
>
> Yes, you can put it here.
> And also please help to submit an ACPICA patch to <devel@...ica.org>.

OK, I think it is a fix to this patch too, I will
prepare a patch soon.

Thanks
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/