linux-kernel - Re: [PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201505230305.50655@pali>
Date:	Sat, 23 May 2015 03:05:50 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Darren Hart <dvhart@...radead.org>,
	platform-driver-x86@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>,
	Gabriele Mazzotta <gabriele.mzt@...il.com>,
	Alex Hung <alex.hung@...onical.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Darren Hart <dvhart@...ux.intel.com>
Subject: Re: [PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules

On Saturday 23 May 2015 00:45:57 Dmitry Torokhov wrote:
> On Thu, May 14, 2015 at 3:54 AM, Pali Rohár <pali.rohar@...il.com>
> wrote:
> > @@ -328,7 +408,9 @@ static void rbtn_notify(struct acpi_device
> > *device, u32 event)
> > 
> >  static int __init rbtn_init(void)
> >  {
> > 
> > -       return acpi_bus_register_driver(&rbtn_driver);
> > +       /* ignore errors so module always loads and exports needed
> > functions */ +       acpi_bus_register_driver(&rbtn_driver);
> > +       return 0;
> 
> Ahem, and if it fails for some reason and you try to unload the
> module what will happen when you call
> acpi_bus_unregister_driver(&rbtn_driver) in rbtn_exit()?\
> 
> Thanks.

I'm thinking about using symbol_request() in dell-laptop.c (instead hard 
dependency) and then not ignoring error here... It could fix this 
problem.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)