linux-kernel - RE: [HPDD-discuss] [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes

Open Source and information security mailing list archives

Message-ID: <DB0C8A206669AC40B1C4E52A8584A6F614C88534@CFWEX01.americas.cray.com>
Date:	Sat, 23 May 2015 03:13:42 +0000
From:	Patrick Farrell <paf@...y.com>
To:	Joe Perches <joe@...ches.com>,
	"Drokin, Oleg" <oleg.drokin@...el.com>
CC:	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"<gregkh@...uxfoundation.org>" <gregkh@...uxfoundation.org>,
	"<kernel-janitors@...r.kernel.org>" <kernel-janitors@...r.kernel.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	"<HPDD-discuss@...1.01.org>" <HPDD-discuss@...1.01.org>,
	"<lustre-devel@...ts.lustre.org>" <lustre-devel@...ts.lustre.org>
Subject: RE: [HPDD-discuss] [PATCH v4 10/13] staging: lustre: lnet: lnet:
 checkpatch.pl fixes

Since it is not actually doing a printk - at least, not necessarily - I like lustre_logmsg.  lustre_output seems too vague.

- Patrick
________________________________________
From: HPDD-discuss [hpdd-discuss-bounces@...ts.01.org] on behalf of Joe Perches [joe@...ches.com]
Sent: Friday, May 22, 2015 7:36 PM
To: Drokin, Oleg
Cc: <devel@...verdev.osuosl.org>; <gregkh@...uxfoundation.org>; <kernel-janitors@...r.kernel.org>; <linux-kernel@...r.kernel.org>; Julia Lawall; <HPDD-discuss@...1.01.org>; <lustre-devel@...ts.lustre.org>
Subject: Re: [HPDD-discuss] [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes

On Sat, 2015-05-23 at 00:25 +0000, Drokin, Oleg wrote:
> On May 22, 2015, at 8:18 PM, Joe Perches wrote:
> >>>> I wonder what is more clear about that in your opinion ve
> >>>> lustre_error/lustre_debug?
> >>>
> >>> The fact that you have to explain this shows that it's
> >>> at least misleading unless you completely understand the
> >>> code.
> >>
> >> Or you know, you might take the function name at the face value
> >> and assume that CERROR means it's an error and CDEBUG means it's a debug message?
> >
> > Maybe, but I think that it'd be better if the mechanism
> > it uses was more plainly named something like lustre_log.
>
> While the idea seems good, the biggest obstacle here is such that
> there's already a thing called lustre log (llog for short too) -
> it's kind of a distributed journal of operations.
>
> Its there a different synonym, I wonder?

Maybe: lustre_printk, lustre_logmsg, lustre_output

_______________________________________________
HPDD-discuss mailing list
HPDD-discuss@...ts.01.org
https://lists.01.org/mailman/listinfo/hpdd-discuss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives