linux-kernel - Re: [char-misc-next 11/11] mei: revamp mei bus code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150524181949.GA13427@kroah.com>
Date:	Sun, 24 May 2015 11:19:49 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	arnd@...db.de, linux-kernel@...r.kernel.org,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [char-misc-next 11/11] mei: revamp mei bus code

On Thu, May 07, 2015 at 03:54:08PM +0300, Tomas Winkler wrote:
> MEI bus was designed around nfc and was hard to extend.
> Instead of hard coded way of adding the devices on the mei bus
> we scan whole me client list and create a device for each
> eligible me client; currently we support only clients with
> single connection and fixed address clients.
> NFC radio name detection is run as a fixup routine
> 
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
>  drivers/misc/mei/Makefile    |   2 +-
>  drivers/misc/mei/bus-fixup.c | 306 ++++++++++++++
>  drivers/misc/mei/bus.c       | 975 ++++++++++++++++++++++++++++---------------
>  drivers/misc/mei/client.c    |   9 +-
>  drivers/misc/mei/init.c      |   5 +-
>  drivers/misc/mei/mei_dev.h   |  24 +-
>  drivers/misc/mei/nfc.c       | 414 ------------------
>  include/linux/mei_cl_bus.h   |  12 +
>  8 files changed, 968 insertions(+), 779 deletions(-)
>  create mode 100644 drivers/misc/mei/bus-fixup.c
>  delete mode 100644 drivers/misc/mei/nfc.c

This is a lot to do in just one patch.  Any chance you can split it up
into reviewable pieces?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/