linux-kernel - Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wrfjzj4u59pb.fsf@ultrasam.lan.trained-monkey.org>
Date:	Sun, 24 May 2015 10:30:56 -0400
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	tolga ceylan <tolga.ceylan@...il.com>
Cc:	Benjamin Romer <benjamin.romer@...sys.com>,
	David Kershner <david.kershner@...sys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	sparmaintainer@...sys.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static

tolga ceylan <tolga.ceylan@...il.com> writes:
> On 05/15/2015 09:22 PM, Tolga Ceylan wrote:
>> visorchipset_file_init() and visorchipset_file_cleanup() functions
>> do not seem to be used from anywhere else and now are declared
>> as static. Sparse emitted "not declared" warnings for these two
>> functions.
>>
>> Signed-off-by: Tolga Ceylan <tolga.ceylan@...il.com>
>> ---
>>   drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
>> index ca22f49..66ae3d0 100644
>> --- a/drivers/staging/unisys/visorbus/visorchipset.c
>> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
>> @@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = {
>>   	.mmap = visorchipset_mmap,
>>   };
>>
>> -int
>> +static int
>>   visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
>>   {
>>   	int rc = 0;
>> @@ -2460,7 +2460,7 @@ cleanup:
>>   	return rc;
>>   }
>>
>> -void
>> +static void
>>   visorchipset_file_cleanup(dev_t major_dev)
>>   {
>>   	if (file_cdev.ops)
>>
>
> I haven't received a response for this patch. Just checking back.
>
> Regards,
> Tolga Ceylan

I don't think there is anything wrong with your patch. However, there is
a lot of active development going to clean up the code in the unisys
tree right now, and your patch conflicts with that. I would prefer to
hold off with this for now, until it settles down a bit.

Cheers,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/