linux-kernel - Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150525163118.GD11588@mwanda>
Date:	Mon, 25 May 2015 19:31:18 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	tolga ceylan <tolga.ceylan@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Cristina Opriceana <cristina.opriceana@...il.com>,
	Haneen Mohammed <hamohammed.sa@...il.com>,
	Greg Donald <gdonald@...il.com>,
	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
	Benoit Taine <benoit.taine@...6.fr>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211:
 ieee80211_softmac.c: auth parse error code byte order fix

Good advice.  This was actually found by Sparse and the changelog should
say:

Sparse complains about this:

ieee80211_softmac.c:1561:16: warning: cast from restricted __le16
ieee80211_softmac.c:1561:16: warning: incorrect type in return expression (different base types)
ieee80211_softmac.c:1561:16:    expected unsigned short
ieee80211_softmac.c:1561:16:    got restricted __le16 [usertype] <noident>

The caller basically only cares about zero and non-zero so it doesn't
affect runtime (except for making an debug message more accurate).

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/