linux-kernel - Re: [PATCH] char:agp:amd64-agp - Change 1 to true for bool type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 25 May 2015 23:22:20 +0200
From:	Richard Weinberger <richard@....at>
To:	Shailendra Verma <shailendra.capricorn@...il.com>
CC:	David Airlie <airlied@...ux.ie>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] char:agp:amd64-agp - Change 1 to true for bool type

Am 25.05.2015 um 23:14 schrieb Shailendra Verma:
> Hello Richard,
> 
> I will separate both the changes and will send the patches to you.
> 
> What issue does this fix? IOW why is assigning 1 wrong?
> 
>>>>> Yes, you are correct. There will be no issue in assigning 1 to the variable. But according to coding guidelines we should only use true/false for bool type variables.

Really? I don't see this in Documentation/CodingStyle and checkpatch.pl does not bark either.
IMHO it is a matter of taste. But the individual maintainer has to decide. :-)

Thanks,
//richard

P.s: Please don't crop the list of CC when replying.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/