linux-kernel - Re: [PATCH] irda: irda-usb: use msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150525.173946.265552397243249712.davem@davemloft.net>
Date:	Mon, 25 May 2015 17:39:46 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	hofrat@...dl.org
Cc:	samuel@...tiz.org, joe@...ches.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irda: irda-usb: use msecs_to_jiffies for conversions

From: Nicholas Mc Guire <hofrat@...dl.org>
Date: Sat, 23 May 2015 14:46:30 +0200

> API compliance scanning with coccinelle flagged:
> 
> Converting milliseconds to jiffies by "val * HZ / 1000" is technically
> is not a clean solution as it does not handle all corner cases correctly.
> By changing the conversion to use msecs_to_jiffies(val) conversion is
> correct in all cases.
> 
> in the current code: 
>   mod_timer(&self->rx_defer_timer, jiffies + (10 * HZ / 1000));
> for HZ < 100 (e.g. CONFIG_HZ == 64|32 in alpha) this effectively results 
> in no delay at all.
> 
> Patch was compile tested for x86_64_defconfig (implies CONFIG_USB_IRDA=m)
> 
> Patch is against 4.1-rc4 (localversion-next is -next-20150522)
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/