linux-kernel - Re: [PATCH v2] ARM: nommu: avoid deprecated source register on mov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 May 2015 08:37:00 +0200
From:	Maxime Coquelin <mcoquelin.stm32@...il.com>
To:	Stefan Agner <stefan@...er.ch>, linux@....linux.org.uk
CC:	arnd@...db.de, will.deacon@....com, u.kleine-koenig@...gutronix.de,
	manabian@...il.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: nommu: avoid deprecated source register on mov

Hi Stefan,

On 05/23/2015 01:25 AM, Stefan Agner wrote:
> In Thumb2 mode, the stack register r13 is deprecated if the
> destination register is the program counter (r15). Similar to
> head.S, head-nommu.S uses r13 to store the return address used
> after configuring the CPU's CP15 register. However, since we do
> not enable a MMU, there will be no address switch and it is
> possible to use branch with link instruction to call
> __after_proc_init.
>
> Avoid using r13 completely by using bl to call __after_proc_init
> and get rid of __secondary_switched.
>
> Beside removing unnecessary complexity, this also fixes a
> compiler warning when compiling a !MMU kernel:
> Warning: Use of r13 as a source register is deprecated when r15
> is the destination register.
>
> Suggested-by: Russell King <rmk+kernel@....linux.org.uk>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
> Changes in v2:
> - Load r7 outside CONFIG_ARM_MPU since its used outside later on
>
>   arch/arm/kernel/head-nommu.S | 21 ++++++++-------------
>   1 file changed, 8 insertions(+), 13 deletions(-)
>
>

You can add my:
Tested-by: Maxime Coquelin <mcoquelin.stm32@...il.com>

Thanks!
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/