linux-kernel - Re: [PATCH v4 3/5] dmaengine: pxa: add pxa dmaengine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432625314.27695.200.camel@x220>
Date:	Tue, 26 May 2015 09:28:34 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	Vinod Koul <vinod.koul@...el.com>,
	Jonathan Corbet <corbet@....net>,
	Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	dmaengine@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 3/5] dmaengine: pxa: add pxa dmaengine driver

Vinod already applied this, so my remarks, if valid, should probably be
handled in a follow up patch.

On Mon, 2015-05-25 at 23:29 +0200, Robert Jarzmik wrote:
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
 
> +config PXA_DMA
> +	bool "PXA DMA support"
> +	depends on (ARCH_MMP || ARCH_PXA)
> +	select DMA_ENGINE
> +	select DMA_VIRTUAL_CHANNELS
> +	help
> +	  Support the DMA engine for PXA. It is also compatible with MMP PDMA
> +	  platform. The internal DMA IP of all PXA variants is supported, with
> +	  16 to 32 channels for peripheral to memory or memory to memory
> +	  transfers.

> --- a/drivers/dma/Makefile
> +++ b/drivers/dma/Makefile

> +obj-$(CONFIG_PXA_DMA) += pxa_dma.o

> --- /dev/null
> +++ b/drivers/dma/pxa_dma.c

> +#include <linux/module.h>

> +MODULE_DEVICE_TABLE(of, pxad_dt_ids);

> +module_platform_driver(pxad_driver);

(The series starting at https://lkml.org/lkml/2015/5/10/131 would allow
to use builtin_platform_driver() for built-in only code.)

> +MODULE_DESCRIPTION("Marvell PXA Peripheral DMA Driver");
> +MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@...e.fr>");
> +MODULE_LICENSE("GPL v2");

This patch added a bool Kconfig symbol. So pxa_dma.c will never be part
of a module. Its code contains a few module specific macros. Was it
actually intended for PXA_DMA to be tristate?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/