linux-kernel - Re: [PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55644026.6010206@suse.de>
Date:	Tue, 26 May 2015 11:43:02 +0200
From:	Hannes Reinecke <hare@...e.de>
To:	"Nicholas A. Bellinger" <nab@...erainc.com>,
	target-devel <target-devel@...r.kernel.org>
CC:	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>,
	Sagi Grimberg <sagig@...lanox.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Nicholas Bellinger <nab@...ux-iscsi.org>
Subject: Re: [PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member

On 05/26/2015 08:57 AM, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@...ux-iscsi.org>
> 
> Hi all,
> 
> Here is v2 series with HCH's recent changes to go ahead and drop
> all se_port + t10_alua_tg_pt_gp_member usage within target-core in
> favor of direct se_lun pointer dereference.
> 
> This includes the original patch + minor fixes, along with two other
> improvements for killing off se_lun->lun_sep_lock via RCU pointer
> access, and converting the remaining se_lun->lun_active busy-wait
> special cases to existing percpu se_lun->lun_ref access.
> 
> Also included in the series is a recently discussed change to go
> ahead and drop an unnecessary core_tpg_register() parameter, and
> all associated target_core_fabric_ops forward declartions within
> fabric driver code.
> 
> The changes since -v1 include:
> 
>   - Move ->lun_se_dev assignments under se_device->se_port_lock
>   - All proper call_rcu() in backend drivers to allow for read-side
>     critical se_device RCU to complete
>   - Add se_device->hba_index to clean up RCU dereferences within
>     scsi_port_show_attr_inst() + scsi_tgt_port_show_attr_inst()
>   - Add various rcu_dereference and lockless_dereference RCU notation
> 
> Please review.
> 
> --nab
> 
For the whole series:

Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/