linux-kernel - Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h8ucbeh18.wl-tiwai@suse.de>
Date:	Tue, 26 May 2015 13:04:35 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Jie Yang <yang.jie@...el.com>
Cc:	broonie@...nel.org, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, liam.r.girdwood@...el.com,
	vivian.zhang@...el.com
Subject: Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint

At Tue, 26 May 2015 19:04:24 +0800,
Jie Yang wrote:
> 
> For some embedded devices, we need reduce code size and data
> footprint as much as possible, e.g. disabling procfs, hw/sw
> params refinement, mmap, dpcm, dapm, compressed API...
> 
> Here add root config menu for those configuration, and
> disable procfs once reduced memory footprint is selected.
> 
> Signed-off-by: Jie Yang <yang.jie@...el.com>
> ---
>  sound/Kconfig | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/sound/Kconfig b/sound/Kconfig
> index 5a240e0..6760dfa 100644
> --- a/sound/Kconfig
> +++ b/sound/Kconfig
> @@ -68,6 +68,22 @@ menuconfig SND
>  
>  if SND
>  
> +menuconfig SND_REDUCED_MEMORY_FOOTPRINT
> +	bool "Reduced Memory Footprint Support"
> +	default n
> +	help
> +	  Say 'Y' to enable Reduced Memory Footprint Support, which may
> +	  reduce code size and data footprint as much as possible.

I'd like to move this into sound/core.
Also, the kconfig name appears a bit too lengthy to me.

> +config SND_PROC_FS
> +	bool "Sound Proc FS Support"
> +	depends on PROC_FS && !SND_REDUCED_MEMORY_FOOTPRINT

This should be
	bool "Sound Proc FS Support" if !SND_REDUCED_MEMORY_FOOTPRINT
	depends on PROC_FS

In this way, this prompt would appear only when
SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts.


thanks,

Takashi

> +	default y
> +	help
> +	  Say 'N' to disable Sound proc FS, which may reduce code size about
> +	  9KB on x86_64 platform.
> +	  If unsure say Y.
> +
>  source "sound/core/Kconfig"
>  
>  source "sound/drivers/Kconfig"
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/