lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 26 May 2015 10:34:07 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Matthew Needes <mneedes@...il.com>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: comedi/drivers/pcl.* coding style fixes

On 26/05/2015 00:41, Matthew Needes wrote:
> pcl812.c / pcl816.c (resend of earlier patch)
>     Fixed indentation problems.
>
> Signed-off-by: Matthew Needes <mneedes@...il.com>
>
> ---
>   drivers/staging/comedi/drivers/pcl812.c | 2 +-
>   drivers/staging/comedi/drivers/pcl816.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
> index 03a3fd6..7474ef9 100644
> --- a/drivers/staging/comedi/drivers/pcl812.c
> +++ b/drivers/staging/comedi/drivers/pcl812.c
> @@ -1155,7 +1155,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>
>   	/* we need an IRQ to do DMA on channel 3 or 1 */
>   	if (dev->irq && board->has_dma)
> -		 pcl812_alloc_dma(dev, it->options[2]);
> +		pcl812_alloc_dma(dev, it->options[2]);
>
>   	/* differential analog inputs? */
>   	switch (board->board_type) {
> diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
> index 1ccb2f1..781b321 100644
> --- a/drivers/staging/comedi/drivers/pcl816.c
> +++ b/drivers/staging/comedi/drivers/pcl816.c
> @@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
>
>   		/*  check whole chanlist */
>   		for (i = 0, segpos = 0; i < chanlen; i++) {
> -			    if (chanlist[i] != chansegment[i % seglen]) {
> +			if (chanlist[i] != chansegment[i % seglen]) {
>   				dev_dbg(dev->class_dev,
>   					"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
>   					i, CR_CHAN(chansegment[i]),
>

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ