linux-kernel - Re: [RFC/RFT PATCH] PCI: move pci_read_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 May 2015 13:57:59 +0100
From:	Will Deacon <will.deacon@....com>
To:	Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Richard Henderson <rth@...ddle.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	David Howells <dhowells@...hat.com>,
	Russell King <linux@....linux.org.uk>,
	Tony Luck <tony.luck@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Ingo Molnar <mingo@...hat.com>,
	Michal Simek <monstr@...str.eu>,
	"yasutake.koichi@...panasonic.com" <yasutake.koichi@...panasonic.com>,
	Chris Zankel <chris@...kel.net>, Arnd Bergmann <arnd@...db.de>,
	Krzysztof Halasa <khalasa@...p.pl>,
	Phil Edworthy <phil.edworthy@...esas.com>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	Jingoo Han <jg1.han@...sung.com>,
	Lucas Stach <l.stach@...gutronix.de>,
	Simon Horman <horms@...ge.net.au>,
	Minghuan Lian <minghuan.Lian@...escale.com>,
	Murali Karicheri <m-karicheri2@...com>,
	Tanmay Inamdar <tinamdar@....com>,
	Kishon Vijay Abraham I <kishon@...com>,
	Thierry Reding <thierry.reding@...il.com>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Jayachandran C <jchandra@...adcom.com>,
	"suravee.suthikulpanit@....com" <suravee.suthikulpanit@....com>
Subject: Re: [RFC/RFT PATCH] PCI: move pci_read_bridge_bases to the generic
 PCI layer

Hi Lorenzo,

On Thu, May 21, 2015 at 02:14:25PM +0100, Lorenzo Pieralisi wrote:
> When a PCI bus is scanned, upon PCI bridge detection the kernel
> has to read the bridge registers to set-up its resources so that
> the PCI resource hierarchy can be validated properly.
> 
> Most if not all architectures read PCI bridge registers in the
> pcibios_fixup_bus hook, that is called by the PCI generic layer
> whenever a PCI bus is scanned.
> 
> Since pci_read_bridge_bases is an arch agnostic operation (and it
> is carried out on all architectures) it can be moved to the generic
> PCI layer in order to consolidate code and remove the respective
> calls from the architectures back-ends.
> 
> The PCI_PROBE_ONLY flag is not checked before calling
> pci_read_bridge_buses in the generic layer since reading the bridge
> bases is not related to resources assignment; this implies that it
> can be carried out safely on PCI_PROBE_ONLY systems too and should
> not affect architectures (alpha, mips) that check the PCI_PROBE_ONLY
> flag before reading the bridge bases.

[...]

> diff --git a/arch/alpha/kernel/pci.c b/arch/alpha/kernel/pci.c
> index 82f738e..cded02c 100644
> --- a/arch/alpha/kernel/pci.c
> +++ b/arch/alpha/kernel/pci.c
> @@ -242,12 +242,7 @@ pci_restore_srm_config(void)
>  
>  void pcibios_fixup_bus(struct pci_bus *bus)
>  {
> -	struct pci_dev *dev = bus->self;
> -
> -	if (pci_has_flag(PCI_PROBE_ONLY) && dev &&
> - 		   (dev->class >> 8) == PCI_CLASS_BRIDGE_PCI) {
> - 		pci_read_bridge_bases(bus);
> -	} 

I appreciate you're basically moving this code ...

> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 062fee6..335d9f2 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -453,7 +453,11 @@ void pci_read_bridge_bases(struct pci_bus *child)
>  	struct resource *res;
>  	int i;
>  
> -	if (pci_is_root_bus(child))	/* It's a host bus, nothing to read */
> +	/*
> +	 * If it is not a PCI bridge there is nothing to read
> +	 */
> +	if (pci_is_root_bus(child) || !dev ||
> +		!((dev->class >> 8) == PCI_CLASS_BRIDGE_PCI))
>  		return;

... to here, but shouldn't we dispense with the class check and use
pci_is_bridge instead? pci_read_bridge_bases is making an assumption
that the header type is BRIDGE, so that seems like the more sensible
check to me.

Also, with these changes, can we now make pci_read_bridge_bases static
(as it has an implicit rdering requirement on the device having been
scanned)?

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/