linux-kernel - Re: [PATCH] staging: rts5208: remove always true comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150526045547.GB3465@sudip-PC>
Date:	Tue, 26 May 2015 10:25:47 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Micky Ching <micky_ching@...lsil.com.cn>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rts5208: remove always true comparison

On Mon, May 25, 2015 at 07:22:40PM +0300, Dan Carpenter wrote:
> On Fri, May 15, 2015 at 03:46:49PM +0530, Sudip Mukherjee wrote:
> > On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote:
> > > On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote:
> > > > the if comparison is always true as anything bitwise and-ing with 0x1E
> > > > can never be equal to 0x03.
> > > > 
> > > > Fixes bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69881
> > > > 
> > > 
> > > It doesn't fix anything though, it just silences the warning.  Warnings
> > > are nice because they let you know that the code is buggy.  It's better
> > > to leave them there instead of making the bugs more complicated to find.
> > 
> > but I am not seeing any warnings. I tried with make W=1, tried with
> > sparse, but still no warning. am i missing something?
> 
> David Binderman is using a static checker of some kind.  I'm not sure
> which.  It might be cppcheck or it might be something private.
Its not cppcheck. I use it when I feel lazy. :) And if it is something
private then only David can see the warning, in that case why do we need
to keep a code which is obviously wrong?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/