linux-kernel - Re: [PATCH] staging: rtl8723au: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wrfjegm34egi.fsf@ultrasam.lan.trained-monkey.org>
Date:	Tue, 26 May 2015 10:10:21 -0400
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Juston Li <juston.h.li@...il.com>
Cc:	Larry.Finger@...inger.net, gregkh@...uxfoundation.org,
	linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723au: fix sparse warning

Juston Li <juston.h.li@...il.com> writes:
> change cast to __le16 to fix the following warning:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to restricted __le16
>
> Signed-off-by: Juston Li <juston.h.li@...il.com>
> ---
>  drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks OK to me

Jes

>
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> index 04d0183..e23af8e 100644
> --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> @@ -1485,7 +1485,7 @@ void Hal_EfuseParseIDCode(struct rtw_adapter *padapter, u8 *hwinfo)
>  	u16 EEPROMId;
>  
>  	/*  Checl 0x8129 again for making sure autoload status!! */
> -	EEPROMId = le16_to_cpu(*((u16 *) hwinfo));
> +	EEPROMId = le16_to_cpu(*((__le16 *) hwinfo));
>  	if (EEPROMId != RTL_EEPROM_ID) {
>  		DBG_8723A("EEPROM ID(%#x) is invalid!!\n", EEPROMId);
>  		pEEPROM->bautoload_fail_flag = true;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/