linux-kernel - Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150526082544.GF11588@mwanda>
Date:	Tue, 26 May 2015 11:25:44 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Gaston Gonzalez <gascoar@...il.com>
Cc:	devel@...verdev.osuosl.org, hamohammed.sa@...il.com,
	paul.gortmaker@...driver.com, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, gdonald@...il.com,
	cristina.opriceana@...il.com
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness
 warning

Btw, the subject should say "fix endian bug".  "silence" means that
their is a warning and possible some messy code but no runtime bug.

On Mon, May 25, 2015 at 07:50:55PM -0300, Gaston Gonzalez wrote:
> On 25/05/15 13:35, Dan Carpenter wrote:
> > This is also wrong then.
> >
> > regards,
> > dan carpenter
> Hi Dan,
> 
> Yes, you are right. It is the next sparse warning in line for that file.
> Including the fix for that, the patch would be as showed below.
> 
> There are similar endianness warnings for other variables in that file,
> like the FIXME in last line of the patch. But keeping in mind the rule
> 'one thing per patch' I guess this should be fixed in other patche/s, right?

The one thing per patch rule is a bit fuzzy.  It depends on how you sell
it a bit.  I wouldn't mind if you fixed the whole function at once.  Or
even all then endian bugs in a file if the patch wasn't too complicated.

But this is also acceptable to fix one struct member so send your
proposed patch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/