linux-kernel - Re: [PATCH v4 06/11] md/raid5: get rid of bio_fits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF1ivSajEe1ec_dCeUec=ER3keKVfhhNvv5pWiti_M++NRrBDQ@mail.gmail.com>
Date:	Tue, 26 May 2015 07:33:45 -0700
From:	Ming Lin <mlin@...nel.org>
To:	Christoph Hellwig <hch@....de>
Cc:	NeilBrown <neilb@...e.de>, Ming Lin <mlin@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Kent Overstreet <kent.overstreet@...il.com>,
	Jens Axboe <axboe@...nel.dk>, Dongsu Park <dpark@...teo.net>,
	linux-raid@...r.kernel.org
Subject: Re: [PATCH v4 06/11] md/raid5: get rid of bio_fits_rdev()

On Mon, May 25, 2015 at 7:17 AM, Christoph Hellwig <hch@....de> wrote:
> On Mon, May 25, 2015 at 05:54:14PM +1000, NeilBrown wrote:
>> Did I write that?  I guess I did :-(
>> I meant *after*.   Don't get rid of bio_fits_rdev until split_bio is in
>> chunk_aligned_read().
>
> I suspect the whole series could use some reordering.

Nice reordering.
I'll do this.

Thanks.

>
> patch 1:
>
>  add ->bio_split and blk_queue_split
>
> patch 2..n:
>
>  one for each non-trivial driver that implements ->merge_bvec_fn to
>  remove it and instead split bios in ->make_request.  The md patch
>  to do the right thing in chunk_aligned_read goes into the general
>  md patch here.  The bcache patch also goes into this series.
>
> patch n+1:
>
>  - add blk_queue_split calls for remaining trivial drivers
>
> patch n+2:
>
>  - remove ->merge_bvec_fn and checking of max_sectors a for all
>    drivers, simplify bio_add_page
>
> patch n+2:
>
>  - remove splitting in blkdev_issue_discard
>
> patch n+3
>
>  - remove bio_fits_rdev
>
> patch n+4
>
>  - remove bio_get_nr_vecs
>
> patch n+4
>
>  - use bio_add_page
>
> patch n+5
>
>  - update documentation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/